new plugin

[Phil Hannent]

Hello,

On 27/12/09 17:06, hariseldon78 at gmail.com wrote:
> hello, i want to share with you the new plugin i am writing. It's name
> is Share Desktop, and it's purpose is to do all that's needed to open a
> direct vnc connection between two buddies. it address the port
> forwarding problem by using upnp, actually by linking an external
> library (libgupnp).
> Here is the code:
> http://github.com/hariseldon78/pidgin-share-desktop
> , if someone wants to try it or have comments please leave a message to
> me or here in mailing list.
I am not a Pidgin developer but I gave it a go as I think its useful.

I have ubuntu 9.10 64-bit and the plugin does not show up in the plugins 
list.

Also I noticed from your source that you have a couple of warnings [1] 
and that you are using // for comments, which I think is not the pidgin 
preferred way.  However I could be wrong on those points.

Regards
Phil Hannent


[1] The warning:

client.c: In function ‘client_accept_connection_cb’:server.c: In 
function ‘start_connection’:

client.c:30: warning: implicit declaration of function ‘purple_debug_misc’
server.c:72: warning: implicit declaration of function ‘purple_debug_misc’
client.c:41: warning: implicit declaration of function ‘fork’
server.c:81: warning: implicit declaration of function ‘fork’
server.c:86: warning: implicit declaration of function ‘execvp’
client.c:47: warning: passing argument 5 of ‘g_regex_replace’ makes 
pointer from integer without a cast
/usr/include/glib-2.0/glib/gregex.h:188: note: expected ‘const gchar *’ 
but argument is of type ‘int’
client.c:55: warning: ignoring return value of ‘system’, declared with 
attribute warn_unused_result
client.c: In function ‘client_handle_connection_request’:
client.c:102: warning: implicit declaration of function 
‘purple_request_action’
server.c: In function ‘no_upnp’:
server.c:105: warning: initialization discards qualifiers from pointer 
target type
server.c: In function ‘upnp_discovery_cb’:
server.c:119: warning: implicit declaration of function 
‘purple_upnp_get_public_ip’
server.c:119: warning: initialization makes pointer from integer without 
a cast
server.c:125: warning: implicit declaration of function 
‘purple_upnp_remove_port_mapping’
server.c:126: warning: implicit declaration of function 
‘purple_upnp_set_port_mapping’
server.c:131: warning: implicit declaration of function ‘upnp_get_ip’
server.c:136: warning: implicit declaration of function 
‘upnp_add_port_mapping’
server.c: In function ‘server_request_connection_cb’:
server.c:153: warning: implicit declaration of function ‘purple_upnp_init’
server.c:154: warning: implicit declaration of function 
‘purple_upnp_discover’
server.c: In function ‘upnp_discovery_cb’:
server.c:131: warning: ‘ip’ may be used uninitialized in this function
mv -f .deps/sharedesk.Tpo .deps/sharedesk.Plo
upnp-functions.c: In function ‘upnp_add_port_mapping_cb’:
upnp-functions.c:27: warning: passing argument 5 of 
‘delete_port_mapping’ from incompatible pointer type
bindings.h:1063: note: expected ‘struct GError **’ but argument is of 
type ‘struct GError *’
upnp-functions.c: In function ‘upnp_ask_external_ip_cb’:
upnp-functions.c:80: warning: format ‘%s’ expects type ‘char *’, but 
argument 2 has type ‘char **’
upnp-functions.c: In function ‘do_loop’:
upnp-functions.c:118: warning: format ‘%d’ expects type ‘int’, but 
argument 2 has type ‘time_t’
mv -f .deps/server.Tpo .deps/server.Plo
mv -f .deps/client.Tpo .deps/client.Plo
mv -f .deps/upnp-functions.Tpo .deps/upnp-functions.Plo
/bin/bash ../libtool --tag=CC   --mode=link gcc -Wall -g 
-DBUILD_TIME=\""`date`"\" -g -O2 -lgssdp-1.0 -lgupnp-1.0 -lsoup-2.4 
-lxml2  -o libpidgin-sharedesk.la -rpath /usr/local/lib sharedesk.lo 
upnp-functions.lo client.lo server.lo
libtool: link: gcc -shared  .libs/sharedesk.o .libs/upnp-functions.o 
.libs/client.o .libs/server.o   -lgssdp-1.0 -lgupnp-1.0 -lsoup-2.4 
/usr/lib/libxml2.so    -Wl,-soname -Wl,libpidgin-sharedesk.so.0 -o 
.libs/libpidgin-sharedesk.so.0.0.0
libtool: link: (cd ".libs" && rm -f "libpidgin-sharedesk.so.0" && ln -s 
"libpidgin-sharedesk.so.0.0.0" "libpidgin-sharedesk.so.0")
libtool: link: (cd ".libs" && rm -f "libpidgin-sharedesk.so" && ln -s 
"libpidgin-sharedesk.so.0.0.0" "libpidgin-sharedesk.so")
libtool: link: ( cd ".libs" && rm -f "libpidgin-sharedesk.la" && ln -s 
"../libpidgin-sharedesk.la" "libpidgin-sharedesk.la" )
make[2]: Leaving directory 
`/home/phil/dev/sharedesktop/pidgin-share-desktop/src'
Making all in po
make[2]: Entering directory 
`/home/phil/dev/sharedesktop/pidgin-share-desktop/po'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory 
`/home/phil/dev/sharedesktop/pidgin-share-desktop/po'
make[2]: Entering directory 
`/home/phil/dev/sharedesktop/pidgin-share-desktop'
make[2]: Leaving directory 
`/home/phil/dev/sharedesktop/pidgin-share-desktop'
make[1]: Leaving directory 
`/home/phil/dev/sharedesktop/pidgin-share-desktop'