Maximum links in messages

Pieter Loubser Pieter.Loubser at mxit.com
Tue Jul 14 03:57:11 EDT 2009


Hi guys,


I am having issues with messages which contains more than 50 links (e.g.
http://www.google.com). If it has more than 50 links Pidgin just does
not show any markup on the message and the output looks terrible and
confusing.


I sniffed around a bit in the Pidgin code and found in
pidgin_conv_write_conv() of gtkconv.c this piece of code....


<code snip>

    /* Awful hack to work around GtkIMHtml's inefficient rendering of
messages with lots of formatting changes.
     * If a message has over 100 '<' characters, strip formatting before
appending it. Hopefully nobody actually
     * needs that much formatting, anyway.
     */
    for (bracket = strchr(displaying, '<'); bracket && *(bracket + 1);
bracket = strchr(bracket + 1, '<'))
        tag_count++;

    if (tag_count > 100) {
        char *tmp = displaying;
        displaying = purple_markup_strip_html(tmp);
        g_free(tmp);
    }

</code snip>


Is this code still relevant and still necessary? Could we maybe not
remove this in version 2.6.0?



Thanks,

Pieter




#####################################################################################
MXit Lifestyle (Pty) Ltd - Join The Evolution
Scanned by MailMarshal - Marshal's comprehensive email content security solution. 

#####################################################################################




More information about the Devel mailing list