Patch review

Paul Aurich paul at
Tue Aug 24 17:55:44 EDT 2010

On 2010-08-24 11:20, Grigory Javadyan wrote:
>  Hi,
> Recently I submitted a patch (ticket #12519, patch for `pounce when my status is...'). It's now in the "patches needing review" category. This is my first contribution to Pidgin and I'm just curious, how long does it usually take to review a patch? 

The honest answer is "Much longer than it should."  That said, it looks
like Jorge/salinasv/Masca made some comments about the patch style,
which you should take a look at (in addition to his, use
purple_debug_error instead of purple_debug(PURPLE_DEBUG_ERROR).

I'll try to take a quick look at it, too, in a few minutes (more
realistically sometime this evening, though)

> Cheers,
> Grigory 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the Devel mailing list