Patch review

[Grigory Javadyan]

Many thanks for the review. I attached an updated version of the patch to the ticket.

> ----- Original message ----- 
> From: "Paul Aurich‎" <paul at darkrain42.org>
> To: "Grigory Javadyan‎" <grigoryj at ovi.com>
> cc: devel at pidgin.im
> Subject: Re: Patch review
> Date: Tue, 24 Aug 2010 14:55:44 -0700
> 
> 
>On 2010-08-24 11:20, Grigory Javadyan wrote:
> >  Hi,
> > Recently I submitted a patch (ticket #12519, patch for `pounce when 
> > my status is...'). It's now in the "patches needing review" 
> > category. This is my first contribution to Pidgin and I'm just 
> > curious, how long does it usually take to review a patch?
> 
> 
> The honest answer is "Much longer than it should."  That said, it looks
> like Jorge/salinasv/Masca made some comments about the patch style,
> which you should take a look at (in addition to his, use
> purple_debug_error instead of purple_debug(PURPLE_DEBUG_ERROR).
> 
> I'll try to take a quick look at it, too, in a few minutes (more
> realistically sometime this evening, though)
> 
> > Cheers,
> > Grigory
> 
> ~P
> << signature.asc >>
>

--------------------------------------------------------------
Ovi Mail: Making email access easy
http://mail.ovi.com