pidgin: 94f37ea0: Show tooltip for ellipsized tab titles.

Sadrul Habib Chowdhury imadil at gmail.com
Mon Feb 8 13:43:02 EST 2010


* Daniel Atallah had this to say on [08 Feb 2010, 11:23:53 -0500]:
> On Sun, Feb 7, 2010 at 15:54, Paul Aurich <paul at darkrain42.org> wrote:
> > On 2010-01-28 17:44, sadrul at pidgin.im wrote:
> >> --- pidgin/gtkconv.c  96f43914d1afcbabc9bae69cc31c3dcc1010f374
> >> +++ pidgin/gtkconv.c  38f2b96cab4ed67da3f9e2254b300a217a3f8316
> >> @@ -9508,6 +9508,24 @@ close_button_entered_cb(GtkWidget *widge
> >>       return FALSE;
> >>  }
> >>
> >> +static gboolean
> >> +gtkconv_tab_set_tip(GtkWidget *widget, GdkEventCrossing *event, PidginConversation *gtkconv)
> >> +{
> >> +#if GTK_CHECK_VERSION(2, 12, 0)
> >> +#define gtk_tooltips_set_tip(tips, w, l, p)  gtk_widget_set_tooltip_text(w, l)
> >> +#endif
> >> +     PangoLayout *layout;
> >> +
> >> +     layout = gtk_label_get_layout(GTK_LABEL(gtkconv->tab_label));
> >> +     gtk_tooltips_set_tip(gtkconv->tooltips, widget,
> >> +                     pango_layout_is_ellipsized(layout) ? gtk_label_get_text(GTK_LABEL(gtkconv->tab_label)) : NULL,
> >> +                     NULL);
> >
> > Someone in #pidgin reported that they were unable to cross-compile
> > WinPidgin from monotone.  It looks like pango_layout_is_ellipsized was
> > added to pango in version 1.16 (released 2007-02-26).
> >
> > Is it possible to bump just the version of pango that WinPidgin is built
> > against, without breaking support for Gtk 2.0?
> 
> Doesn't using a Pango 1.16 specific function break GTK+ 2.0
> compatibility on all OSes?

82bea91d8b15d548f2eefa3fb33e7cb7252df802 should fix the issue.

Cheers,
Sadrul




More information about the Devel mailing list