bug 13298 - does it affect other code?

[Duncan Berriman]

Hi Mark,

I'm not sure anything else is affected which is why I am asking.

 I just saw that other code checks the value of network to see if it is MSN_NETWORK_UNKNOWN for instance notification.c, contact.c, user.c from what I can see.

I just wondered if the change that has been made is the only one that is needed.

I'm sure your fix is probably correct, my knowledge is very limited so really just asking to confirm that should be the only change required.

I have not tried your fix but simply added the following to msn.c for now in add_pending_buddy before the existing if test.

if (network == MSN_NETWORK_UNKNOWN) {
  network = MSN_NETWORK_PASSPORT;
}

I've tested the above and it appears to work.

Duncan


-----Original Message-----
From: Mark Doliner [mailto:mark at kingant.net] 
Sent: 02 March 2011 17:00
To: Duncan Berriman
Cc: devel at pidgin.im
Subject: Re: bug 13298 - does it affect other code?

On Wed, Mar 2, 2011 at 1:18 AM, Duncan Berriman <duncan at dcl.co.uk> wrote:
> Just looking at bug 13298 before testing it (MSN unable to add contacts).
>
> Having done a quick grep will this issue not effect other modules such 
> asnotification.c and possibly contact.c, user.c?

I only see one place in the msn prpl that sends the particular fqy query to check a buddy's network (that query is the one that we think the return value changed and caused the problem).  What other functionality do you think would be affected?

--Mark

--
This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.