pidgin: 385542a8: I don't see any reason to copy then free...

Mark Doliner mark at
Mon Mar 7 21:26:18 EST 2011

On Mon, Mar 7, 2011 at 6:12 PM, Paul Aurich <paul at> wrote:
> And markdoliner at spoke on 03/06/2011 10:45 PM, saying:
>> ----------------------------------------------------------------------
>> Revision: 385542a8270ac30d2121b533494264a28cd04423
>> URL:
>> Changelog:
>> I don't see any reason to copy then free this variable.  Also let's call
>> it username to be consistent with the rest of our code
>> Changes against parent 6118d1117f31a7fc8db4bd5431af400a7b46ff17
>>   patched  libpurple/protocols/jabber/jabber.c
> The string is mutated (to remove a trailing '/') via the strchr, and I
> didn't think it was good form to mutate account->username like that.
> It's an ugly hack because internal to the prpl, everything is pedantic
> about JIDs, and "paul at" isn't a valid one (but some UIs
> currently generate that due to the username split stuff.

Oh!  You're right.  Somehow I missed that.  I'll disapprove this.


More information about the Devel mailing list