pidgin: d1328041: disapproval of revision '8e7b47f18e014b8...
mark at kingant.net
Tue Oct 4 04:02:29 EDT 2011
On Tue, Oct 4, 2011 at 12:38 AM, Mark Doliner <mark at kingant.net> wrote:
> Hey Kevin (or anyone), I'm wondering what the reason was to disapprove
> this comment? It seems reasonable to me to remove
I talked to Kevin in the XMPP muc and his reason was basically that he
doesn't know what the intended purpose is for PURPLE_CONV_TYPE_MISC
and he's betting Andrew doesn't know either (I also don't know), and
Kevin thinks we should try to assess whether it's useful before
getting rid of it.
That sounded reasonable to me. So, uh, anyone know if
PURPLE_CONV_TYPE_MISC serves a purpose?
- Andrew, thanks for tackling such a large portion of the 3.0.0 API
cleanup! Your commits look great to me, and I definitely appreciate
all the work you're donig.
- I'm sure someone will try to answer your API-related email questions
- Some Pidgin devs think it's useful for committers to be available in
IRC or the XMPP multi-user chat while making commits, in case someone
has questions about them. Chat room info here:
More information about the Devel