/cpw/tomkiewicz/gg11: b5341ea06a72: Gadu-Gadu: fix conferences u...

Tomasz Wasilczyk tomkiewicz.groups at gmail.com
Thu Sep 20 14:07:18 EDT 2012


I have no idea, how I missed that. Anyway, I will fix all convention
issues in GG prpl later.

Tomek

2012/9/19 Jorge Villaseñor <salinasv at gmail.com>:
> On Wed, Sep 19, 2012 at 7:40 AM, Tomasz Wasilczyk
> <tomkiewicz at cpw.pidgin.im> wrote:
>> Changeset: b5341ea06a7267c07ce31f12906063a15ab174f9
>> Author:  Tomasz Wasilczyk <tomkiewicz at cpw.pidgin.im>
>> Date:    2012-09-19 14:40 +0200
>> Branch:  default
>> URL: http://hg.pidgin.im/cpw/tomkiewicz/gg11/rev/b5341ea06a72
>>
>> Description:
>>
>> Gadu-Gadu: fix conferences used together with multilogon
>>
>> diffstat:
>>
>>  libpurple/protocols/gg/message-prpl.c |  11 ++++++++++-
>>  1 files changed, 10 insertions(+), 1 deletions(-)
>>
>> diffs (21 lines):
>>
>> diff --git a/libpurple/protocols/gg/message-prpl.c b/libpurple/protocols/gg/message-prpl.c
>> --- a/libpurple/protocols/gg/message-prpl.c
>> +++ b/libpurple/protocols/gg/message-prpl.c
>> @@ -270,7 +270,16 @@ void ggp_message_got_multilogon(PurpleCo
>>         msg->gc = gc;
>>         msg->time = ev->time;
>>         msg->user = ev->sender; /* not really a sender*/
>> -       msg->type = GGP_MESSAGE_GOT_TYPE_MULTILOGON;
>> +
>> +       if (ev->chat_id != 0)
>> +       {
>> +               msg->type = GGP_MESSAGE_GOT_TYPE_CHAT;
>> +               msg->chat_id = ev->chat_id;
>> +       }
>> +       else
>> +       {
>> +               msg->type = GGP_MESSAGE_GOT_TYPE_MULTILOGON;
>> +       }
>>
>>         ggp_message_format_from_gg(msg, ev->xhtml_message);
>>         if (ggp_message_request_images(gc, msg))
>>
>
> Just to notice that this braces usage is out of the convention.
>
> We want to have consistency all over the code.
>
> --
> Masca
>
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing on usenet and in e-mail?
>
> _______________________________________________
> Devel mailing list
> Devel at pidgin.im
> http://pidgin.im/cgi-bin/mailman/listinfo/devel




More information about the Devel mailing list