/soc/2013/ankitkv/gobjectification: ff659a466f19: OCD

[John Bailey]

On 08/03/2013 12:07 PM, Ankit Vani wrote:
> diff --git a/libpurple/notify.h b/libpurple/notify.h
> --- a/libpurple/notify.h
> +++ b/libpurple/notify.h
> @@ -54,8 +54,8 @@ typedef void  (*PurpleNotifyCloseCallbac
>  typedef enum
>  {
>  	PURPLE_NOTIFY_MESSAGE = 0,   /**< Message notification.         */
> -	PURPLE_NOTIFY_EMAIL,         /**< Single email notification.   */
> -	PURPLE_NOTIFY_EMAILS,        /**< Multiple email notification. */
> +	PURPLE_NOTIFY_EMAIL,         /**< Single email notification.    */
> +	PURPLE_NOTIFY_EMAILS,        /**< Multiple email notification.  */
>  	PURPLE_NOTIFY_FORMATTED,     /**< Formatted text.               */
>  	PURPLE_NOTIFY_SEARCHRESULTS, /**< Buddy search results.         */
>  	PURPLE_NOTIFY_USERINFO,      /**< Formatted userinfo text.      */
> @@ -716,7 +716,7 @@ PurpleNotifyUiOps *purple_notify_get_ui_
>  /*@}*/
>  
>  /**************************************************************************/
> -/** @name Notify Subsystem                                         */
> +/** @name Notify Subsystem                                                */
>  /**************************************************************************/
>  /*@{*/

I'll admit to not knowing libpurple code as well as I should these days, but do
we have a good reason to handle notification for one e-mail differently from
notification from multiple e-mails?  If not, shouldn't we simplify this and just
handle all e-mail notifications the same, just with a count of 1 in the
single-message case?

John


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://pidgin.im/pipermail/devel/attachments/20130803/314c38c6/attachment.sig>