/soc/2013/ankitkv/gobjectification: ff659a466f19: OCD

Richard Laager rlaager at wiktel.com
Sat Aug 3 13:36:54 EDT 2013

On Sat, 2013-08-03 at 12:17 -0400, John Bailey wrote:
> do
> we have a good reason to handle notification for one e-mail differently from
> notification from multiple e-mails?  If not, shouldn't we simplify this and just
> handle all e-mail notifications the same, just with a count of 1 in the
> single-message case?

I looked at the code a bit just now.

libpurple translates notify_emails(gc, 1, ...) into
notify_email(gc, ...).

Pidgin translates notify_email(gc, ...) into notify_emails(gc, 1, ...)

So it seems to me we should drop the singular form throughout the stack.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://pidgin.im/pipermail/devel/attachments/20130803/47b632a0/attachment.sig>

More information about the Devel mailing list