/soc/2013/ankitkv/gobjectification: ff659a466f19: OCD

[Eion Robb]

The singular is a lot easier to use from a prpl point of view, not having
to make extra glists. The singular and plural functions had different
behaviour in pidgin too, the single would show up in pidgin in full whereas
the plural would just show something like "account has 3 new messages" as a
summary
On 4/08/2013 5:37 AM, "Richard Laager" <rlaager at wiktel.com> wrote:

> On Sat, 2013-08-03 at 12:17 -0400, John Bailey wrote:
> > do
> > we have a good reason to handle notification for one e-mail differently
> from
> > notification from multiple e-mails?  If not, shouldn't we simplify this
> and just
> > handle all e-mail notifications the same, just with a count of 1 in the
> > single-message case?
>
> I looked at the code a bit just now.
>
> libpurple translates notify_emails(gc, 1, ...) into
> notify_email(gc, ...).
>
> Pidgin translates notify_email(gc, ...) into notify_emails(gc, 1, ...)
>
> So it seems to me we should drop the singular form throughout the stack.
>
> --
> Richard
>
> _______________________________________________
> Devel mailing list
> Devel at pidgin.im
> http://pidgin.im/cgi-bin/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20130804/5e19ec08/attachment.html>