/soc/2013/ankitkv/gobjectification: ff659a466f19: OCD

[Jorge Villaseñor]

On Sat, Aug 3, 2013 at 12:36 PM, Richard Laager <rlaager at wiktel.com> wrote:

> On Sat, 2013-08-03 at 12:17 -0400, John Bailey wrote:
> > do
> > we have a good reason to handle notification for one e-mail differently
> from
> > notification from multiple e-mails?  If not, shouldn't we simplify this
> and just
> > handle all e-mail notifications the same, just with a count of 1 in the
> > single-message case?
>
> I looked at the code a bit just now.
>
> libpurple translates notify_emails(gc, 1, ...) into
> notify_email(gc, ...).
>
> Pidgin translates notify_email(gc, ...) into notify_emails(gc, 1, ...)
>
> So it seems to me we should drop the singular form throughout the stack.
>


IIRC it was legacy, I don't know why it was not marked as deprecated.

-- 
Masca

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20130803/80c74874/attachment.html>