crash in novell_ssl_connect_error

[Ethan Blanton]

Olaf Hering spake unto us the following wisdom:
> I'm running pidgin-2.7.10 as included in openSuSE 11.4. If the network
> connection is flaky, pidgin crashes in novell.c:1680
[ snip ]
> Current mainline has the same code. I lost my gdb sesseion during the
> last crash, so cant tell what pointer in line 1680 was invalid or NULL.

Unfortunately, the Novell plugin was donated by a corporate entity, is
no longer maintained, and none of the Pidgin developers have a server
to check it against.  We would happily accept patches to improve it
from a developer who does have access to a server.

> I suggest to add proper checks before assign a value to ->data.

There may be some level of defensive programming that can be performed
without a server, of course.  I haven't examined this code carefully
to see if, for example, simply aborting the operation leaves things
in a sane state.

Ethan