Deprecated GTK Function Replacements

[Michael McConville]

On Tue, Jul 07, 2015 at 10:08:59PM -0400, Michael McConville wrote:
> On Tue, Jul 07, 2015 at 10:02:57PM -0400, Elliott Sales de Andrade wrote:
> > On 7 July 2015 at 21:54, Ethan Blanton <elb at pidgin.im> wrote:
> > > Ethan Blanton spake unto us the following wisdom:
> > >> Michael McConville spake unto us the following wisdom:
> > >> > On Tue, Jul 07, 2015 at 07:49:38PM -0400, Michael McConville wrote:
> > >> > > I also just realized that I committed an incomplete version of the
> > >> > > patch.  :P  Using three different test machines is quite an experience.
> > >> > >
> > >> > > Eion and I are discussing adding a GTK compat function to reduce the
> > >> > > amount of boilerplate. It sounds like a good idea to me. I'll check back
> > >> > > in when I have one committed.
> > >> >
> > >> >     https://hg.pidgin.im/soc/2015/mmcc/main/rev/9415ac64b6fa
> > >> >
> > >> > I still need to test it with 3.16.x.
> > >>
> > >> This looks much better to me.  I like it.
> > >
> > > Actually, let me qualify that -- I think this should be
> > > pidgin_label_set_alignment, not gtk_label_set_alignment.  But that's a
> > > small detail.
> > 
> > On the one hand, this one is not a strict one-to-one compatibility
> > function, but on the other hand, everything in gtk3compat.h is not
> > intended to be public.
> 
> Yeah, I was going off of gtk_grid_attach_defaults() and
> gtk_grid_attach_full(), which are defined in pidgin/gtk3compat.h and
> don't seem to be existing GTK functions. I can change their names to
> pidgin_* too. Objections?

To clarify, I think changing them to pidgin_* is a good idea so that
people don't go looking for them in the GTK API docs.