Fixing File Transfer in 3.0

Michael McConville mmcconville at
Tue Jul 21 11:42:56 EDT 2015

File transfer has been broken in 3.0 for a while:

I found two issues:

	* the recipient was accounting for each received byte twice (the
	  obvious and reported issue)
	* redundant calls to the transfer completion function were
	  slightly, non-deterministically truncating files

This fixes both for me on XMPP:

Because each protocol uses the file transfer API in its own way, this
might break some. However, I'd call this "unambiguously less broken".
Any objections?

More information about the Devel mailing list