Fixing File Transfer in 3.0

[Jorge Villaseñor]

On Tue, Jul 21, 2015 at 8:42 AM, Michael McConville <mmcconville at mykolab.com
> wrote:

> File transfer has been broken in 3.0 for a while:
>
>         https://developer.pidgin.im/ticket/16001
>
> I found two issues:
>
>         * the recipient was accounting for each received byte twice (the
>           obvious and reported issue)
>         * redundant calls to the transfer completion function were
>           slightly, non-deterministically truncating files
>
> This fixes both for me on XMPP:
>
>         https://hg.pidgin.im/soc/2015/mmcc/main/rev/acd5549cf5d6
>
> Because each protocol uses the file transfer API in its own way, this
> might break some. However, I'd call this "unambiguously less broken".
> Any objections?
>
>
Looks good.


I wonder if each protocol uses the file transfer API in its own way means
the API is broken and we should change it.

-- 
Masca

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pidgin.im/pipermail/devel/attachments/20150726/42171961/attachment.html>