Yahoo Japan Removal

Richard Laager rlaager at wiktel.com
Thu Jun 18 05:01:25 EDT 2015


I'm just looking at the diff online:
https://hg.pidgin.im/soc/2015/mmcc/main/rev/0cf05a71fef7

You have a whitespace issue in the second hunk of 
libpurple/protocols/yahoo/yahoo_aliases.c. You're using spaces and the 
rest of the code is using tabs.

Likewise twice in the 4th hunk in the same file. Also, there you've 
twice got a variable declaration (escaped_alias) that's no longer at the 
top of the block.

Spaces instead of tabs in libpurple/protocols/yahoo/yahoo_filexfer.c.

Spaces instead of tabs in the both hunks of 
libpurple/protocols/yahoo/yahoochat.c.

Spaces instead of tabs in the second hunk of 
libpurple/protocols/yahoo/ymsg.c. And the 9th, which is "build the raw 
packet and send it". And the 10th and 11th.

Otherwise, nothing jumps out at me as crazy. It all seems pretty 
straightforward.

-- 
Richard



More information about the Devel mailing list