Yahoo Japan Removal

Michael McConville mmcconville at
Thu Jun 18 13:21:31 EDT 2015

On Thu, Jun 18, 2015 at 04:01:25AM -0500, Richard Laager wrote:
> I'm just looking at the diff online:
> You have a whitespace issue in the second hunk of
> libpurple/protocols/yahoo/yahoo_aliases.c. You're using spaces and the rest
> of the code is using tabs.
> Likewise twice in the 4th hunk in the same file. Also, there you've twice
> got a variable declaration (escaped_alias) that's no longer at the top of
> the block.
> Spaces instead of tabs in libpurple/protocols/yahoo/yahoo_filexfer.c.
> Spaces instead of tabs in the both hunks of
> libpurple/protocols/yahoo/yahoochat.c.
> Spaces instead of tabs in the second hunk of
> libpurple/protocols/yahoo/ymsg.c. And the 9th, which is "build the raw
> packet and send it". And the 10th and 11th.
> Otherwise, nothing jumps out at me as crazy. It all seems pretty
> straightforward.

Thanks for that.

I just committed a fix:

More information about the Devel mailing list