2.12.1 Release

[David Woodhouse]

On Mon, 2017-10-02 at 17:41 +0100, David Woodhouse wrote:
> On Mon, 2017-10-02 at 17:39 +0200, Jakub Adam wrote:
> > 
> > David, please check the patch I attached to Pidgin issue #17246, which should deal with
> > the missing "cname" property in FsRawParticipant. If it works for you I'll open a PR on
> > Bitbucket for that change.
>
> Thanks. Right now I'm having trouble even getting to the point I was
> last week where it brings up the call UI and crashes; will keep working
> on that.

Aha, that's because the experiments with our own Farstream transmitters
(or even FsShmTransmitter) aren't even getting as far as emitting
'farstream-new-local-candidate', so we never even get as far as the
code that crashes. If I go back to my very first hack I can reproduce
the crash — and confirm that your patch also fixes it. This is what I
have:

#if 1 /* FIXME make this work... */
	const gchar *uuid = chime_call_get_uuid(chat->call);
	PurpleMedia *media = purple_media_manager_create_media(purple_media_manager_get(),
							       chat->conv->account,
							       "fsrawconference",
							       uuid,
							       FALSE);
	printf("media for %s %p\n", uuid, media);
	if (media) {
		gboolean r = purple_media_add_stream(media, "chime", uuid,
						     PURPLE_MEDIA_AUDIO, FALSE, "nice", 0, NULL);
		printf("Add stream %s\n", r ? "succeeded" : "failed");

		GList *cands = g_list_append (NULL,
					      purple_media_candidate_new(NULL, 1,
						PURPLE_MEDIA_CANDIDATE_TYPE_HOST, PURPLE_MEDIA_NETWORK_PROTOCOL_UDP, "/tmp/src1", 0));

		purple_media_add_remote_candidates(media, "chime", uuid, cands);

	}
#endif


Note that even changing from "nice" to "shm" means that I never get the
farstream-new-local-candidate message that triggers the crash, although
I do still get the Pidgin call UI. We're still a long way from having
this *working*, but I think your patch is going to be necessary by the
time we do get there.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4938 bytes
Desc: not available
URL: <https://pidgin.im/pipermail/devel/attachments/20171002/29d09f1d/attachment.bin>