chat windows opened in maximized state, stealing focus

Olaf Hering olaf at aepfle.de
Fri Jun 14 10:45:56 EDT 2019


Am Fri, 14 Jun 2019 16:25:50 +0200
schrieb Konrad Gräfe <kglists at teamblind.de>:

> The chats must be added to the buddy list.

They are there. How would they be able to autojoin?
Anyway, while I did read the mentioned github issue I did not realize the rocketchat plugin is still broken after two years. A variant of this patch is still required:

diff --git a/libpurple/protocols/rocketchat/librocketchat.c b/libpurple/protocols/rocketchat/librocketchat.c
index 56bb086b91..5a963f069b 100644
--- a/libpurple/protocols/rocketchat/librocketchat.c
+++ b/libpurple/protocols/rocketchat/librocketchat.c
@@ -2959,6 +2959,7 @@ rc_join_chat(PurpleConnection *pc, GHashTable *chatdata)
 		chatconv = purple_conversations_find_chat_with_account(id, ya->account);
 	}
 	if (chatconv != NULL && !purple_chat_conversation_has_left(chatconv)) {
+		if (0)
 		purple_conversation_present(PURPLE_CONVERSATION(chatconv));
 		return;
 	}
@@ -2968,6 +2969,7 @@ rc_join_chat(PurpleConnection *pc, GHashTable *chatdata)
 		purple_conversation_set_data(PURPLE_CONVERSATION(chatconv), "id", g_strdup(id));
 	}
 
+	if (0)
 	purple_conversation_present(PURPLE_CONVERSATION(chatconv));
 
 	if (!g_hash_table_contains(ya->group_chats, id)) {

Now it works as expected. Thanks!

Olaf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: Digitale Signatur von OpenPGP
URL: <https://lists.pidgin.im/pipermail/devel/attachments/20190614/b9f9a0a0/attachment.sig>


More information about the Devel mailing list