[pidgin-security] possible segfault in perl wrapper

Tomasz Wasilczyk tomkiewicz at cpw.pidgin.im
Sun Apr 14 19:44:49 EDT 2013


2013/4/15 Tomasz Wasilczyk <tomkiewicz at cpw.pidgin.im>:
> 2013/4/14 Mark Doliner <mark at kingant.net>:
>>> by replacing sv_setpv with sv_setpvn
>>
>> I'm not super familiar with the perl/C API, but where would you do
>> that?  The Network.c file is autogenerated.  Maybe you would need to
>> add a PPCODE block to Network.xs?  Maybe just copy the autogenerated
>> definition from Network.c to Network.xs and make this change?
>
> I'll copy autogenerated code, clean it up and fix.

And here is (see attachment) proposed fix. I've tested it, and it
works fine with my simple test. Any objections?

I'm waiting for acknowledge to remove it from 3.0.0.

Tomek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: perl-ip-atoi-fix.patch
Type: application/octet-stream
Size: 478 bytes
Desc: not available
URL: <http://pidgin.im/cgi-bin/mailman/private/security/attachments/20130415/d1a2668a/attachment.obj>


More information about the security mailing list