[Pidgin] #1317: Nicer "Smiley Themes" preferences tab

Pidgin trac at pidgin.im
Sat Jun 2 03:45:15 EDT 2007


#1317: Nicer "Smiley Themes" preferences tab
---------------------------+------------------------------------------------
  Reporter:  lithium       |       Owner:       
      Type:  enhancement   |      Status:  new  
  Priority:  minor         |   Milestone:       
 Component:  pidgin (gtk)  |     Version:  2.0.1
Resolution:                |    Keywords:       
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by nix_nix):

 Of course, having asked for help, I figured it out. The fundamental
 problem with "remove" is that the currently selected theme is going away,
 so you have to select a new one. To correctly select a new theme, you do a
 purple_prefs_set_string(PIDGIN_PREFS_ROOT "/smileys/theme",
 new_theme->name) when you're about to delete current_smiley_theme from the
 smiley_themes GSList. You choose new_theme as follows:
   - The next theme in the smiley_themes GSList, if it's not NULL,
   - otherwise, the first theme, if current_smiley_theme is not the first
 theme,
   - otherwise NULL (We Should Never Get Here (TM) - especially since
 removing 'none' is explicitly checked for and disallowed removal in
 gtkprefs.c)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1317#comment:8>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list