[Pidgin] #1344: fix for some build warnings

Pidgin trac at pidgin.im
Mon Jun 4 12:14:09 EDT 2007


#1344: fix for some build warnings
----------------------------+-----------------------------------------------
  Reporter:  o_sukhodolsky  |       Owner:  rlaager 
      Type:  patch          |      Status:  assigned
  Priority:  minor          |   Milestone:  2.0.2   
 Component:  pidgin (gtk)   |     Version:  2.0.1   
Resolution:                 |    Keywords:          
   Pending:  0              |  
----------------------------+-----------------------------------------------
Comment (by o_sukhodolsky):

 Replying to [comment:35 rlaager at pidgin.im]:
 > (In [7523dcce0ac4ae98a74e3611efc953b8e0e20cde]) A patch from
 o_sukhodolsky to fix a couple warnings like this:
 >
 > dbus-bindings.c: In function 'purple_status_type_find_with_id_DBUS':
 > dbus-bindings.c:6801: warning: passing argument 1 of
 'purple_dbus_pointer_to_id_error' discards qualifiers from pointer target
 type
 >
 > I changed the patch to use gconstpointer instead of const gpointer.
 >
 > References #1344

 I still see warnings :(
 {{{
 dbus-bindings.c:1051: warning: passing argument 1 of
 'purple_dbusify_GList' discards qualifiers from pointer target type
 dbus-bindings.c:6246: warning: passing argument 1 of
 'purple_dbusify_GList' discards qualifiers from pointer target type
 dbus-bindings.c:6830: warning: passing argument 1 of
 'purple_dbusify_GList' discards qualifiers from pointer target type
 dbus-bindings.c:7484: warning: passing argument 1 of
 'purple_dbusify_GList' discards qualifiers from pointer target type
 }}}

 this is because you have not applied part of the fix I've provided
 {{{
 35      @@ -55,7 +55,7 @@
 36
 37       #define PURPLE_DBUS_POINTER_TO_ID(id, ptr, error)
 \
 38           G_STMT_START {
 \
 39      -       id = purple_dbus_pointer_to_id_error(ptr,error);
 \
 40      +       id = purple_dbus_pointer_to_id_error((const
 gpointer)ptr,error);\
 41              CHECK_ERROR(error);
 \
 42           } G_STMT_END
 43
 }}}

 is it intended, you it was just missed?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:48>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list