[Pidgin] #1344: fix for some build warnings
Pidgin
trac at pidgin.im
Mon Jun 4 12:23:00 EDT 2007
#1344: fix for some build warnings
----------------------------+-----------------------------------------------
Reporter: o_sukhodolsky | Owner: rlaager
Type: patch | Status: assigned
Priority: minor | Milestone: 2.0.2
Component: pidgin (gtk) | Version: 2.0.1
Resolution: | Keywords:
Pending: 0 |
----------------------------+-----------------------------------------------
Comment (by o_sukhodolsky):
Replying to [comment:47 rlaager at pidgin.im]:
> (In [d490669094dfedb728db24b519343e169ca782f9]) Rework the Trillian log
reader code to make it easier to understand.
> References #1344
nice improvement :)
May I also suggest some changes (will attach them shortly). The diffs are
rather long but this is only because I've used strstr() to find end of
file (instead of current iteration).
also I've added use of strstr() in two more placed instead of cycles,
And finally, I've moved temp variable our of the cycle which replace all
links with hrefs, this
allows to not allocate new GString for every iteration, instead I continue
with the processing of
the line and collect "unlinkified string" in temp. (Hope the explanation
was clear :)
--
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:49>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list