[Pidgin] #384: Close icons in the tabs are cut off

Pidgin trac at pidgin.im
Mon May 28 13:17:13 EDT 2007


#384: Close icons in the tabs are cut off
---------------------------+------------------------------------------------
  Reporter:  hbons         |       Owner:  seanegan
      Type:  enhancement   |      Status:  new     
  Priority:  minor         |   Milestone:          
 Component:  pidgin (gtk)  |     Version:  2.0     
Resolution:                |    Keywords:          
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by lithium):

 I was about to file the same thing. Using the close icon from gnome-icon-
 theme (hbons' screenshot) this is not even very visible, but there are
 themes that use more of the canvas that what this icon does. One example
 is the new gtk-close icon that ships whith GTK 2.11.x now. Also, the used
 gtkrc theme seens to affect this also (see my comparison screenshot, using
 the new GTK icon and various theme engines).

 andy753421: You ware most likely using an older GTK version which still
 had the old (chinese looking) close icon and no other icon theme which
 would overwrite it.

 Here is a list of what close icons are possible and how big they actually
 are:

 => GTK, up to 2.10.x: gtk-close is on a 20x20 canvas, the actual image is
 12x11 px

 => gnome-icon-theme: gtk-close is availabe in 16x16 and 22x22 versions,
 with actual sizes of 12x11 and 16x17 px

 => GTK 2.11.x: has the close icon in both 16x16 and 20x20 sizes, with
 actual sizes of 14x15 px and 18x19 px

 IMHO the "right" thing to do is to make the button large enough to fit a
 16x16 icon completely into it. Pidgin should then fetch the 16x16 close
 icon from the icon theme or gtk as a fallback. in case of GTK 2.10, the
 build-in 20x20 icon has to be used somehow, or the same icon cropped to
 16x16 could be shipped with Pidgin as a fallback.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/384#comment:4>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list