[Pidgin] #1359: purple_mkstemp method change, now raises assertion failure ...

Pidgin trac at pidgin.im
Mon May 28 14:53:31 EDT 2007


#1359: purple_mkstemp method change, now raises assertion failure ...
------------------------+---------------------------------------------------
  Reporter:  msfbrasil  |       Owner:       
      Type:  defect     |      Status:  new  
  Priority:  minor      |   Milestone:       
 Component:  libpurple  |     Version:  2.0.0
Resolution:             |    Keywords:       
   Pending:  1          |  
------------------------+---------------------------------------------------
Changes (by rlaager):

  * pending:  0 => 1

Comment:

 Is this the diff of the changes that broke things? Are you on Windows or
 *nix? If you're on Windows, the net effect of this change was nothing. If
 you're on *nix, it went from mkstemp to g_mkstemp(), which should be safe.
 What assertion failure are you getting? Make sure you are up-to-date with
 liburple MTN and have no other changes. Then apply this diff in reverse
 (patch -p0 -R) and see if that fixes your problem.

 {{{
 #
 #
 # patch "libpurple/util.c"
 #  from [d27709ef550a88d7747916438366d0a603a98b10]
 #    to [9a57160bf1c8c0bbdb43e2ec4c94d687a31d28e5]
 #
 ============================================================
 --- libpurple/util.c    d27709ef550a88d7747916438366d0a603a98b10
 +++ libpurple/util.c    9a57160bf1c8c0bbdb43e2ec4c94d687a31d28e5
 @@ -2529,11 +2529,7 @@ purple_mkstemp(char **fpath, gboolean bi

         if((tmpdir = (gchar*)g_get_tmp_dir()) != NULL) {
                 if((*fpath = g_strdup_printf("%s" G_DIR_SEPARATOR_S "%s",
 tmpdir, purple_mkstemp_templ)) != NULL) {
 -#ifdef _WIN32
                         fd = g_mkstemp(*fpath);
 -#else
 -                       fd = mkstemp(*fpath));
 -#endif
                         if(fd == -1) {
                                 purple_debug(PURPLE_DEBUG_ERROR,
 "purple_mkstemp",
                                                    "Couldn't make \"%s\",
 error: %d\n",
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1359#comment:1>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list