[Pidgin] #1344: fix for some build warnings
Pidgin
trac at pidgin.im
Tue May 29 01:23:25 EDT 2007
#1344: fix for some build warnings
----------------------------+-----------------------------------------------
Reporter: o_sukhodolsky | Owner: rlaager
Type: patch | Status: assigned
Priority: minor | Milestone: 2.0.2
Component: pidgin (gtk) | Version: 2.0.1
Resolution: | Keywords:
Pending: 0 |
----------------------------+-----------------------------------------------
Comment (by rlaager):
A couple comments from a skimming of the patch...
1. We don't do the (NULL == some_var) thing.
2. This is useless, as g_malloc() never returns NULL:
{{{
278 read = g_malloc(data->length + 2);
279 + g_return_val_if_fail(read != NULL, g_strdup(""));
}}}
--
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:2>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list