[Pidgin] #1344: fix for some build warnings
Pidgin
trac at pidgin.im
Tue May 29 01:25:56 EDT 2007
#1344: fix for some build warnings
----------------------------+-----------------------------------------------
Reporter: o_sukhodolsky | Owner: rlaager
Type: patch | Status: assigned
Priority: minor | Milestone: 2.0.2
Component: pidgin (gtk) | Version: 2.0.1
Resolution: | Keywords:
Pending: 0 |
----------------------------+-----------------------------------------------
Comment (by rlaager):
I don't think that g_return_if_fail() is acceptable here. Those checks can
be compiled out. I think this sort of error checking should be done with
unconditional if statements.
{{{
498 + result = fwrite(data->data, 1, data->len, fp);
499 + g_return_if_fail(result == data->len);
}}}
--
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:3>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list