[Pidgin] #1344: fix for some build warnings
Pidgin
trac at pidgin.im
Tue May 29 15:17:49 EDT 2007
#1344: fix for some build warnings
----------------------------+-----------------------------------------------
Reporter: o_sukhodolsky | Owner: rlaager
Type: patch | Status: assigned
Priority: minor | Milestone: 2.0.2
Component: pidgin (gtk) | Version: 2.0.1
Resolution: | Keywords:
Pending: 0 |
----------------------------+-----------------------------------------------
Comment (by o_sukhodolsky):
Replying to [comment:8 rlaager]:
> Replying to [comment:7 o_sukhodolsky]:
> > Replying to [comment:4 rlaager]:
> > > 1. In log_reader.c, you've unmarked strings for translation. Here's
one of at least two. Why?
> > {{{
> > 307 - line =
_("User is offline.");
> > 308 + line =
"User is offline.";
> > }}}
> >
> > well, I've remove _() only in the lines where you have tried to assign
const string to non-const
> > one) and compilers warns about this). As far as I can see these are
the only such places in
> > 2.0.1 sources.
>
> This needs to be fixed in the correct way (which I don't know without
looking at the code), as these strings are marked for translation for a
reason.
Well, in this case it looks like you need to call dgettext() directly w/o
unnecessary casting to (const char*). Is this correct way, or you
have/use ather way to get translated message?
--
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:11>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list