[Pidgin] #1344: fix for some build warnings
Pidgin
trac at pidgin.im
Tue May 29 15:42:49 EDT 2007
#1344: fix for some build warnings
----------------------------+-----------------------------------------------
Reporter: o_sukhodolsky | Owner: rlaager
Type: patch | Status: assigned
Priority: minor | Milestone: 2.0.2
Component: pidgin (gtk) | Version: 2.0.1
Resolution: | Keywords:
Pending: 0 |
----------------------------+-----------------------------------------------
Comment (by rlaager):
_() is a macro that calls gettext(). It is defined in libpurple/internal.h
for us. We cast it to const char, as per the man page of gettext, which
says, "The return type ought to be const char *, but is char * to avoid
warnings in C code predating ANSI C." That call is fine.
Basically, line needs to be changed to be const char, and then all the
warnings that pop-up from that need to be fixed, which is going to be non-
trivial, because the log reader code sucks (I know, I wrote it a LONG time
ago). If you want to tackle this, that'd be amazing, but you certainly
don't have to. ;)
--
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:12>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list