[Pidgin] #4052: extra 'buddy-status-changed' signals

[Pidgin]

#4052: extra 'buddy-status-changed' signals
-----------------------+----------------------------------------------------
Reporter:  andy753421  |       Owner:  MarkDoliner 
    Type:  defect      |      Status:  new         
Priority:  minor       |   Component:  AIM         
 Version:  2.2.2       |    Keywords:  oscar status
 Pending:  0           |  
-----------------------+----------------------------------------------------
 I noticed that the '''buddy-status-changed''' signal is getting sent
 multiple times each time a AIM buddy changes their away message. I did
 some backtraces and it seems like it is being caused by the
 '''purple_got_infoblock()''' function in '''oscar.c:3033'''.

 I'm pretty sure that this function doesn't need to call
 '''purple_blist_update_buddy_status()''' because that is being done
 directly '''from purple_parse_oncoming()'''. I think the infoblock
 function might not be needed at all because the only other thing it seems
 to do is call '''serv_got_alias()''' to set aliases (for icq?) but that's
 done in ''two other'' places as well ('''oscar.c:3860''' and
 '''oscar.c:4877''').

 I'll try looking though the code and doing some more testing before
 submitting a patch. I'm not that experienced with the codebase and
 randomly deleting functions seems a little risky to me :)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4052>
Pidgin <http://pidgin.im>
Pidgin