[Pidgin] #1187: Send Custom Emoticons in MSN

Pidgin trac at pidgin.im
Tue Nov 27 10:12:29 EST 2007


#1187: Send Custom Emoticons in MSN
-----------------------+----------------------------------------------------
  Reporter:  salinasv  |       Owner:  rlaager 
      Type:  patch     |      Status:  assigned
  Priority:  minor     |   Milestone:  2.3.1   
 Component:  MSN       |     Version:  2.0     
Resolution:            |    Keywords:          
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by msfbrasil):

 Hello There!!!

 I have some questions about the implementation of this patch that are:

 1- Why methods "pidgin_account_custom_smiley_add" and
 "pidgin_account_custom_smiley_del" are not implemented inside the
 libpurple (on account API) as "purple_*" ?

 2- I think the peace of code bellow, present on
 "pidgin_account_add_to_smiley_list" method of "gtkaccount.c" file should
 be inside libpurple too. Don't you agree ?

 {{{
 +       if(pc && prpl_info && prpl_info->add_smiley)
 +               prpl_info->add_smiley(pc, smile, file, FALSE);
 }}}

 Best regards!!!

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1187#comment:73>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list