[Pidgin] #5212: MSNP14 hangs on connection to login.live.com

[Pidgin]

#5212: MSNP14 hangs on connection to login.live.com
--------------------------+-------------------------------------------------
  Reporter:  NTAuthority  |       Owner:  khc             
      Type:  defect       |      Status:  new             
  Priority:  minor        |   Milestone:  Activate MSNPV14
 Component:  MSN          |     Version:  2.4.0           
Resolution:               |    Keywords:                  
   Pending:  0            |  
--------------------------+-------------------------------------------------
Comment (by Maiku):

 I just tried out your patch and it works quite well. I just want to
 comment on two things. Firstly, I'm not certain doubling the buffer size
 is all that necessary. For a normal login for me, the packet sizes I get
 are 5392, 13941, 2147, 6469, 1468, 16880, 1709, and 761. There are only
 two that go over the 8192 buffer. One of which is the address book which
 should be severely shortened once we get partial address book updates
 working.

 Secondly, There's a bit of logic in the current version that I didn't see
 duplicated in your patch. In the case of:

 {{{
 cnt < 0 && errno == EAGAIN && count == 0
 }}}

 it returns right away. It doesn't need to process the packet if it's an
 EAGAIN error and nothing new has been read. I get several of these between
 one of the headers and the rest of the packet. So, without it, it
 unnecessarily processes the packet several times before the whole packet
 is retrieved.

 I'll upload what I came up with to see what you think. It includes your
 patch for simplicity.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5212#comment:8>
Pidgin <http://pidgin.im>
Pidgin