[Pidgin] #5613: Problems detected using static analysis tool

[Pidgin]

#5613: Problems detected using static analysis tool
---------------------------+------------------------------------------------
  Reporter:  julianday     |       Owner:  lschiere
      Type:  patch         |      Status:  new     
  Priority:  minor         |   Milestone:          
 Component:  unclassified  |     Version:  2.4.1   
Resolution:                |    Keywords:          
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by sadrul):

 There's an incredible amount of unnecessary casting in the current patch.
 I think they should be removed (unless the compiler cries in their
 absence). Some changes are also wrong (e.g. the first few blocks in
 blist.c). There are also some unnecessary NULL checks (e.g. in
 myspace/message.c). Please remove those.

 There seem to be some valid removal of redundant code. They should just be
 removed, instead of being wrapped inside '#if 0'.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5613#comment:6>
Pidgin <http://pidgin.im>
Pidgin