[Pidgin] #3319: MSN group name display support

[Pidgin]

#3319: MSN group name display support
-----------------------+----------------------------------------------------
 Reporter:  manphiz    |        Owner:  khc
     Type:  patch      |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.2.0      |   Resolution:     
 Keywords:  msn group  |  
-----------------------+----------------------------------------------------

Comment(by felipec):

 Replying to [comment:39 SuperMMX]:
 > Replying to [comment:38 felipec]:
 > > Temporary hacks that mess with libpurple core are bad. If I was a
 libpurple dev I wouldn't merge your patch until it's done properly.
 >
 > Does my patch mess libpurple ? I don't think so. It can be removed if
 there is a better solution available. (There is, but it will change a lot
 of interfaces, so it does not apply here).

 Sigh. Do you think that adding fields in the middle of structures doesn't
 break binary compatibility?

 > > Two group chats, with different people, the same buddy is in both. Or
 you have a group chat with your buddy there, and also IM.
 >
 > This doesn't matter at all. The group member can set different nick in
 different group with some command (/nn in xiaoi).

 I don't know what's xiaoi, and I don't care, setting a nick would update
 the 'special alias' in all the conversations.

 > In all my comments, the *buddy* means the bot that forwards messages
 between group members. While the group member or message sender stands for
 the real person that actually sends messages, who may not in the buddy
 list.

 I didn't read all the messages, I just read the patch, which is supposed
 to implement the 'P4-Context' but it's doing it the wrong way.

 > > I wrote the code to display that debugging message, I didn't think
 adding the passport was necessary, so what?
 > >
 > > Look at what's sent over the wire:
 > > http://www.hypothetic.org/docs/msn/switchboard/messages.php
 >
 > I still didn't see the passport of the *original message sender* in the
 group.

 Didn't see where?

 Can you focus on the 'P4-Context' field in general usage, instead of
 whatever strange thing you are trying to do with it?

 Or you can ignore my comments and hope the devs will accept your patch. My
 bet is that it will be ignored for a few more years in the current state.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3319#comment:40>
Pidgin <http://pidgin.im>
Pidgin