[Pidgin] #3319: MSN group name display support
Pidgin
trac at pidgin.im
Tue Dec 2 10:45:18 EST 2008
#3319: MSN group name display support
-----------------------+----------------------------------------------------
Reporter: manphiz | Owner: khc
Type: patch | Status: new
Milestone: | Component: MSN
Version: 2.2.0 | Resolution:
Keywords: msn group |
-----------------------+----------------------------------------------------
Comment(by SuperMMX):
Replying to [comment:40 felipec]:
> Sigh. Do you think that adding fields in the middle of structures
doesn't break binary compatibility?
I do, so I agree that it is some kind hack. But no rush here. We can apply
the patch later in next major version which is definitely broken.
Or we can move the field to the end of the structure. I added there
because I think it is a logical place to go for this temporary fix.
> I don't know what's xiaoi, and I don't care, setting a nick would update
the 'special alias' in all the conversations.
I don't think such a nick should apply to all conversations (and there is
only one currently). Because it is per message. And it should go with the
message, but it is not possible without changing many interfaces and
function calls.
> Didn't see where?
The message dump in the link you provided. Or I misunderstood you?
> I didn't read all the messages, I just read the patch, which is supposed
to implement the 'P4-Context' but it's doing it the wrong way
> Can you focus on the 'P4-Context' field in general usage, instead of
whatever strange thing you are trying to do with it?
I have given my effort on this with a short term solution (the patch) and
a long term solution (see [comment:17 My comment 17]). Why I am arguing
here is because
I think we have different understanding of how P4-context should behavior.
And we should be on the same page.
> Or you can ignore my comments and hope the devs will accept your patch.
My bet is that it will be ignored for a few more years in the current
state.
I myself use the patch happily without any problems. I care because this
can benefit more people and make Pidgin better.
--
Ticket URL: <http://developer.pidgin.im/ticket/3319#comment:41>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list