[Pidgin] #7734: XMPP avatar code calculating wrong checksum

[Pidgin]

#7734: XMPP avatar code calculating wrong checksum
------------------------+---------------------------------------------------
 Reporter:  darkrain42  |        Owner:  deryni
     Type:  patch       |       Status:  new   
Milestone:              |    Component:  XMPP  
  Version:  2.5.2       |   Resolution:        
 Keywords:              |  
------------------------+---------------------------------------------------

Comment(by deryni):

 The fourth chunk of the new patch is still a bit off current_hash can't be
 NULL. I believe this

 {{{
 if (!vcard_hash || (vcard_hash && (current_hash[0] != '\0') &&
                     (strcmp(vcard_hash, current_hash)))) {
     /* Publish the icon we have locally. */
 } else if (current_hash[0] != '\0') {
     /* Set the hash we currently have as our avatar_hash. */
 }
 }}}

 does the same thing and is a little more clear. I'm noting it here since I
 didn't want to ask darkrain42 to spin yet another patch and I wanted it
 somewhere until I get to committing it.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7734#comment:6>
Pidgin <http://pidgin.im>
Pidgin