[Pidgin] #4533: file transfer support for yahoo

Pidgin trac at pidgin.im
Wed Jan 2 11:30:02 EST 2008

#4533: file transfer support for yahoo
  Reporter:  madthanu   |       Owner:               
      Type:  patch      |      Status:  new          
  Priority:  minor      |   Milestone:               
 Component:  libpurple  |     Version:  2.3.1        
Resolution:             |    Keywords:  file transfer
   Pending:  0          |  
Comment (by datallah):

 This is a pretty big patch.  Good job with the comments, it is nice to see
 why certain things were done instead of having to figure them out.

 I haven't yet had a chance to fully review it, but here are some issues
 that I noticed:

  - A number of strings that shouldn't be translatable are marked as such
 (e.g. `_(";expires=")`)
  - There are `//` comments - these are not ok to use, they're not C89
 compliant and cause problems with some compilers.

 I'm somewhat concerned about the change to advertise a client version,
 particularly because I suspect that there are a number of things that we
 do differently than that client does.

 There are also some other things like using spaces instead of tabs and
 such that will need to be fixed.

Ticket URL: <http://developer.pidgin.im/ticket/4533#comment:2>
Pidgin <http://pidgin.im>

More information about the Tracker mailing list