[Pidgin] #393: Add receive Handwritten messages, Winks and Voice Clips to MSN

Pidgin trac at pidgin.im
Fri Jan 4 02:41:58 EST 2008

#393: Add receive Handwritten messages, Winks and Voice Clips to MSN
  Reporter:  notak  |       Owner:  khc                 
      Type:  patch  |      Status:  assigned            
  Priority:  minor  |   Milestone:                      
 Component:  MSN    |     Version:  2.0                 
Resolution:         |    Keywords:  msn handwritten wink
   Pending:  0      |  
Comment (by QuLogic):

 Alright, so I've looked at the separate patch for handwritten messages.
 It's looking obvious that it won't work with MSNP14 since
 `msn_message_parse_payload` has been changed, and it is used in more
 places now that will need to be updated. There are also a couple things I
 don't quite get, as well.

 For example, `GHashTable *multipartmessages`; I assume it is supposed to
 index Message-ID's to their initial !MsnMessage. However, shouldn't this
 be a member of a !MsnSwitchboard or something similar? Presumably it's
 random, but I see no reason why the Message-ID could not be the same
 between different conversations, or over different accounts, and using one
 table sounds like we'll just being confusing messages together. Also, I
 don't see you removing anything from this table.

 I don't really think `msn_message_parse_payload` should be returning a new
 !MsnMessage. If it returns NULL, then the original `msg` passed in as the
 first parameter is not destroyed, and it's a bit messy to fix up. Perhaps
 just re-writing it as `msn_message_new_from_payload` or some similar
 change would work better.

 Also, do you have an example of some data? That parsing stuff in
 `slpcall.c` looks a bit more complicated than it needs to be.

 Finally, I think `datacast_table` in `switchboard.c` can probably be
 removed (for the split patch).

Ticket URL: <http://developer.pidgin.im/ticket/393#comment:26>
Pidgin <http://pidgin.im>

More information about the Tracker mailing list