[Pidgin] #6140: XML logger

[Pidgin]

#6140: XML logger
------------------------+---------------------------------------------------
  Reporter:  samuel     |       Owner:                    
      Type:  patch      |      Status:  new               
  Priority:  minor      |   Milestone:                    
 Component:  libpurple  |     Version:  2.4.2             
Resolution:             |    Keywords:  xml logger history
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by samuel):

 Replying to [comment:2 deryni]:
 > What changes to pidgin do you feel are necessary for an xml logger to be
 written?

 Current logger write function gets parameters like sender alias, but not
 important parameters like sender/receiver id, and so..

 Logger read function just reads log and return a text. But logger should
 not return just text, it should return metainformation like sender,
 reciever, time, flags, etc. as described in the post. And this is not
 possible without rewrite of finch and pidgin.

 I think that the log information should be stored in the ''PurpleLog''
 structure and write/read function should just store/read the content of
 this structure to/from a file. And the logviewer shoul work directly with
 this structure, not with the plain or formated text.

 > What about the current logging system doesn't allow you to just create
 an xml logger plugin?

 I think there shoul be one good logger logging all important information.
 I do not want many different loggers. I want one which will replace old
 loggers and this should not be done by plugin.

 >You are aware that the current logging system allows for plugins to add
 log types, correct?

 Yes, I know about this.

 > Why do you want to store the account and buddy alias in the log? I can't
 imagine most people will want to see old aliases when looking at old logs,
 will they?

 Perhaps you are right, there is no big reason to store aliases in the log.
 But I think there is no big reason to do not do that. Logviewer do not
 have to show these old aliases, but perhaps sometime in future somebody
 will change a mind and find the way how to use this information.
 Not all the information stored in the log must be used. If there is a
 chance that some information could be used in future, store it. It does
 not matter that it will not be used, nobody was hurt because there is
 somewhere stored unimportant information. Nobody read plain logs, they use
 logviewer what can filtrate what is relevant and what not.

 > Assuming we want the alias stored in the log, why would we want to store
 the alias again with each message? Why would we need to store both to and
 from for each message? (For IMs only one side is needed and for chats only
 one side will generally exist.)

 In chats there are different senders of message, so it makes sense to
 store who has sent the message. And, similarly, I can send a message to
 different persons, so the receiver should be stored.

 > Why would the message itself not be the cdata of the <message/> tag?

 It can be a cdata of the <message/> tag, if you think it is better idea.

 > Also two small details. Firstly, your diffs were taken backwards (they
 show your changes as removals not additions) and secondly the word is
 "standard" not "standart".

 I am sorry for that. I just corrected it, now it should be ok.



 Thank you for your interest.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/6140#comment:4>
Pidgin <http://pidgin.im>
Pidgin