[Pidgin] #5876: ability to hide away/idle buddies as well as mobile buddies

[Pidgin]

#5876: ability to hide away/idle buddies as well as mobile buddies
---------------------------+------------------------------------------------
  Reporter:  sumitk        |       Owner:                             
      Type:  patch         |      Status:  new                        
  Priority:  minor         |   Milestone:  Patches Needing Improvement
 Component:  pidgin (gtk)  |     Version:  2.4.2                      
Resolution:                |    Keywords:                             
   Pending:  0             |  
---------------------------+------------------------------------------------
Changes (by rlaager):

 * cc: jviggiano, justineatworld, chaddaniels, boydster2000,
 cphuntington97, spidey3 (added)
  * keywords:  path for Ticket #4112 =>
  * milestone:  => Patches Needing Improvement

Comment:

 Thanks for the patch. I haven't tested it, but in general, it looks well
 done. However, this patch adds a bunch of API. While that's not inherently
 bad, I think we can simplify this patch some and reduce a bunch of it:

 1. purple_blist_node_get_bool_with_default() wouldn't be necessary if you
 flipped that from "show_away" to "hide_away" and flipped the logic related
 to it.

 2. I'm concerned about the, purple_presence_is_away(),
 purple_status_is_away(), and purple_status_type_is_away() functions.
 You're checking for a primitive of PURPLE_STATUS_AWAY. I haven't tested
 this, but doesn't that mean that someone who is "Extended Away" would not
 count as as away here?

 Instead, could you replace calls to purple_presence_is_away() with
 !purple_presence_is_available()?

 3. Is it really necessary to allow people to show certain buddies when
 they're away but this option is on? If so, why? Are those people going to
 be the same ones you would want to see when they're offline? If so, then
 those options can be merged.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5876#comment:1>
Pidgin <http://pidgin.im>
Pidgin