[Pidgin] #5876: ability to hide away/idle buddies as well as mobile buddies

[Pidgin]

#5876: ability to hide away/idle buddies as well as mobile buddies
---------------------------+------------------------------------------------
  Reporter:  sumitk        |       Owner:                             
      Type:  patch         |      Status:  new                        
  Priority:  minor         |   Milestone:  Patches Needing Improvement
 Component:  pidgin (gtk)  |     Version:  2.4.2                      
Resolution:                |    Keywords:                             
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by sumitk):

 1. purple_blist_node_get_bool_with_default() wouldn't be necessary if you
 flipped that from "show_away" to "hide_away" and flipped the logic related
 to it.

 >> Isn't that a missing/needed API anyway? Give an option on what should
 be the return value in case key(string) is not found ??
 >>
 >> neway, I can get rid of that API if you really think its not needed.


 2. I'm concerned about the, purple_presence_is_away(),
 purple_status_is_away(), and purple_status_type_is_away() functions.
 You're checking for a primitive of PURPLE_STATUS_AWAY. I haven't tested
 this, but doesn't that mean that someone who is "Extended Away" would not
 count as as away here?
 >>
 >>
 >>You are right. Should be in.

 Instead, could you replace calls to purple_presence_is_away() with
 !purple_presence_is_available()?
 >>
 >> I think offline, invisible, dnd will fall in !available. More, I think
 there is a need for this API.


 3. Is it really necessary to allow people to show certain buddies when
 they're away but this option is on? If so, why? Are those people going to
 be the same ones you would want to see when they're offline? If so, then
 those options can be merged.

 >> Think of this case - "set idle when away for n mins" setting is on. But
 actually buddy is there. (people working on desktop machines and signed on
 laptop next to them can set them away after 'n' minutes but actually there
 are there) but may not want to display if he is offline.

 >> You know people may be in as away (not invisible) and answer some
 urgent stuffs.
 >> What's you think ?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5876#comment:2>
Pidgin <http://pidgin.im>
Pidgin