[Pidgin] #2067: Support for Animated GIFs (MSN, AIM, ICQ, YAHOO) Buddy Icons

Pidgin trac at pidgin.im
Tue Oct 21 18:03:10 EDT 2008


#2067: Support for Animated GIFs (MSN, AIM, ICQ, YAHOO) Buddy Icons
-----------------------------+----------------------------------------------
 Reporter:  praveenmarkandu  |        Owner:              
     Type:  task             |       Status:  closed      
Milestone:                   |    Component:  pidgin (gtk)
  Version:  2.0.2            |   Resolution:  wontfix     
 Keywords:                   |  
-----------------------------+----------------------------------------------

Comment(by datallah):

 Replying to [comment:11 IlRazziatore]:
 > I read the comment ( and i post the comment about the Animated PNG ).

 APNG isn't really relevant to this ticket.  If you want to add support for
 APNG, the right place to do so is in gdk-pixbuf.

 > 1] Read and save gif. You nead GTK write/read the file for you? Why?
 Pidgin can't use other library? If GTK can't sand message pidgin don't
 send message? Pidgin ins't a front end of GTK, GTK is only one of library
 Pidgin use. If GKT don't read/write GIF file okay you can use an other
 library or read/wirte file your-self.

 What is displayed in the IMHtml is a !GdkPixbuf - that is what is being
 saved, not the original file; consequently the library needs to support
 saving whatever format we would like it to save as. Of course it is
 theoretically possible to change how this works, but IMO it isn't worth
 complicating life just so you can save animated gifs from the IM buffer.

 > Legaly you can't read the gif as image but no-one can say nothing to you
 if you semply read the byte and copy it.

 Actually, I don't think there are any more legal issues, it is just a
 matter of historical reasons that gdk-pixbuf doesn't support it, perhaps
 they would accept a patch to do so if it was reasonable.

 > When Pidgin recived an gif animated it display it, why not save it? You
 can't write a simply dump file rutine?

 We actually do, incoming animated gifs will be stored in the icon cache in
 ~\.purple\icons.  Perhaps it would be reasonable to support copying the
 file from the cache, if present instead of saving the !GdkPixbuf that is
 displayed.

 >
 > If you want i do it for you ( and i will do that myself but i don't
 understend wher put it in the pidgin source structure... )

 If you feel like working on making the saving of images from the IM
 history copy the cached file as a preferred method of saving, I think such
 a patch would be accepted (assuming it is done correctly).


 > You say isn't a Pidgin problem, I do not agree.
 >
 > 2] The animated emotions how are send? As File ( all the file in raw
 mode, with header ... ) or as an uncompressed animation?
 >
 > If animated emotiocns are sand as raw file, you don't need decopress it
 you don't need "read" it. You don't need a library ( GTK ) read it for
 you. You nead only read the file ( and the file system do that for you )
 and sand byte by byte the file.
 >
 > If animated emoticons are sand as uncompressed animations... why don't
 use APNG localy?

 As I mentioned - if the gif you're trying to use doesn't need to be scaled
 (to fit the constraints of what the protocol accepts) to be sent, it will
 work as a buddy icon (this may not be the case for custom emoticons, I
 haven't tested it).  If it does need to be scaled, then gdk-pixbuf needs
 to be able to do that for us to be able to send it.


 >
 > 3] You say "APNG wouldn't be all that useful anyway if other clients
 can't read them either".
 >
 > I'm not agree again. I use Pidgin, my sister use Pidgin, a lot of my
 friend use Pidgin. Why we can't use APNG between us?
 >
 > eMule extend the eDonkey protocol, at the begin no-one have eMule but
 this did not important. If two people had eMule they used the new feature
 otherwise no, patience.

 Your eMule analogy doesn't quite fit - in most cases, the server is
 involved and only certain image formats (and sizes of images) are
 supported by the IM protocol; we can't just send whatever we want.
 Perhaps for some protocols we could do this, but once again, we need gdk-
 pixbuf support.

 >
 > There are 3 tickets duplicate of this so the user want this features...
 You are always convinced that it isn't a Pidgin problem?

 Just because people don't like it doesn't mean it is a problem.  As
 always, good patches that do something reasonable (adding a direct
 dependency to something like a gif library isn't something I would
 consider reasonable) are welcome.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2067#comment:12>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list