[Pidgin] #4845: Tons and tons of "Unable To Retrieve Buddy List" dialogs.

[Pidgin]

#4845: Tons and tons of "Unable To Retrieve Buddy List" dialogs.
--------------------+-------------------------------------------------------
 Reporter:  rtaft   |        Owner:  MarkDoliner
     Type:  defect  |       Status:  new        
Milestone:          |    Component:  AIM        
  Version:  2.3.1   |   Resolution:             
 Keywords:          |  
--------------------+-------------------------------------------------------

Comment(by rtaft):

 From the comments from 2008-04-16 on oscar.c, it attempts to get the buddy
 list every 30 seconds.  So work has been done recently to make this not so
 nasty, I'll take one popup every 30 seconds over getting hammered with a
 ton of them at once any day.  According to the log, you should still be
 able to message buddies by manually entering their SN into a chat window,
 but the overall server issue tends to go away within 15 minutes.

 Perhaps since this is still bothering people, just show the error once.

 @@ -4915,10 +4915,12 @@ static int purple_ssi_parseerr(OscarData
         purple_debug_error("oscar", "ssi: SNAC error %hu\n", reason);

         if (reason == 0x0005) {
 -               purple_notify_error(gc, NULL, _("Unable To Retrieve Buddy
 List"),
 -                                                 _("The AIM servers were
 temporarily unable to send your buddy list.  Your buddy list is not lost,
 and will probably become available in a few minutes."));
 +
                 if (od->getblisttimer > 0)
                         purple_timeout_remove(od->getblisttimer);
 +               else
 +                       purple_notify_error(gc, NULL, _("Unable To
 Retrieve Buddy List"),
 +                                                         _("The AIM
 servers were temporarily unable to send your buddy list.  Your buddy list
 is not lost, and will probably become available in a few minutes."));
                 od->getblisttimer = purple_timeout_add(30000,
 purple_ssi_rerequestdata, od);
                 return 1;
         }

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4845#comment:12>
Pidgin <http://pidgin.im>
Pidgin