[Pidgin] #9013: Change hardcoded CLOSE_CONV_TIMEOUT_SECS to user selected value

Pidgin trac at pidgin.im
Thu Apr 23 14:43:32 EDT 2009


#9013: Change hardcoded CLOSE_CONV_TIMEOUT_SECS to user selected value
------------------------------------+---------------------------------------
 Reporter:  dlou99                  |        Owner:              
     Type:  patch                   |       Status:  pending     
Milestone:  Patches Needing Review  |    Component:  pidgin (gtk)
  Version:  2.5.5                   |   Resolution:              
 Keywords:                          |  
------------------------------------+---------------------------------------
Changes (by dlou99):

  * status:  pending => new


Comment:

 Replying to [comment:6 deryni]:
 > The intent of this feature as designed was (largely) to prevent people
 from getting log files consisting entirely of "Bye." when they closed
 their window too early. It additionally means that should a conversation
 end, and within short order need to be restarted the previous history will
 be retained for some small amount of time. For periods longer then that
 the History plugin works to retrieve older history from conversation logs.
 >
 > I feel ten minutes is reasonable because it (wildly) more than
 adequately handles the "Bye." case and provides a fairly reasonable
 approximation to the amount of time I think a conversation stands to be
 resurrected during. I would be equally happy with 5 or 15 minutes and
 personally I do not even use this feature.
 >
 > Adding preferences is something we do carefully as we already have quite
 a few and they add cost to maintenance so we try to make sure they are
 really necessary before doing so.

 I can understand the reluctance to add preferences.  As a compromise, how
 about making it adjustable on an expert basis?  The (2nd) attached patch
 doesn't add to the prefs dialog, but still makes the timeout adjustable
 via prefs.xml

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9013#comment:7>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list