[Pidgin] #10119: report completion in libpurple File transfer API

Pidgin trac at pidgin.im
Fri Aug 28 22:47:43 EDT 2009


#10119: report completion in  libpurple File transfer API
---------------------+------------------------------------------------------
 Reporter:  kenshin  |        Owner:           
     Type:  patch    |       Status:  new      
Milestone:           |    Component:  libpurple
  Version:  2.6.1    |   Resolution:           
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by darkrain42):

 Replying to [comment:1 kenshin]:
 > {{{
 > ============================================================
 > --- libpurple/protocols/yahoo/yahoo_filexfer.c
 9847f1ca4caf96df6df2a215310eca27d075b059
 > +++ libpurple/protocols/yahoo/yahoo_filexfer.c
 48b2de4019e51355ce8987ab88e2ee74d889bf3f
 > @@ -509,9 +509,6 @@ static gssize yahoo_xfer_write(const guc
 >               return 0;
 >       }
 >
 > -     if ((purple_xfer_get_bytes_sent(xfer) + len) >=
 purple_xfer_get_size(xfer))
 > -             purple_xfer_set_completed(xfer, TRUE);
 > -
 >       return len;
 >  }
 > }}}
 >
 > for prpl yahoo as this operation is performed by the caller


 Why not in `yahoo_xfer_read`, too?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10119#comment:2>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list