[Pidgin] #8415: Crash after token update for ABContactUpdate

[Pidgin]

#8415: Crash after token update for ABContactUpdate
---------------------+------------------------------------------------------
 Reporter:  Dimmuxx  |           Owner:  khc   
     Type:  defect   |          Status:  closed
Milestone:  2.5.5    |       Component:  MSN   
  Version:           |      Resolution:  fixed 
 Keywords:           |   Launchpad_bug:        
---------------------+------------------------------------------------------
Changes (by qulogic at pidgin.im):

  * status:  new => closed
  * resolution:  => fixed
  * milestone:  => 2.5.5


Comment:

 (In [5c1b1793e5a18e4e9272157a0d24d41c2d96647f]):[[BR]]
 I was hoping this wouldn't be necessary, but it seems that the possibility
 has increased now that we update the display name in the AB.
 If two SOAP requests fail because of outdated tokens for the same server,
 it's possible that the second one could fail miserably. That's because
 both
 times, the update request would be made with the original cipher secret.
 However, the response for the first request would overwrite this secret,
 and the second response would attempt decryption with this new secret
 instead of the original.

 Now, we queue up the callbacks if a token-update is already in progress.
 This results in a single update if there happens to be multiple failures
 at
 a time, and it stops this incorrect decryption problem.

 Fixes #8415.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8415#comment:1>
Pidgin <http://pidgin.im>
Pidgin