[Pidgin] #8415: Crash after token update for ABContactUpdate

[Pidgin]

#8415: Crash after token update for ABContactUpdate
---------------------+------------------------------------------------------
 Reporter:  Dimmuxx  |           Owner:  khc
     Type:  defect   |          Status:  new
Component:  MSN      |         Version:     
 Keywords:           |   Launchpad_bug:     
---------------------+------------------------------------------------------
 Adium crashed after a token update for ABContactUpdate because it seems it
 didn't decrypt a SOAP response from contacts.msn.com properly.


 {{{
 Exception Type:  EXC_BAD_ACCESS (SIGBUS)
 Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000000
 Crashed Thread:  0

 Thread 0 Crashed:
 0   libpurple                           0x164cff24 nexus_got_update_cb +
 524
 1   libpurple                           0x164dd945 msn_soap_handle_body +
 496
 2   libpurple                           0x164ddddb msn_soap_process + 1048
 3   libpurple                           0x164ddfb4 msn_soap_read_cb + 433
 4   com.apple.CoreFoundation            0x9034d920 __CFSocketDoCallback +
 640
 5   com.apple.CoreFoundation            0x9034ef65 __CFSocketPerformV0 +
 133
 6   com.apple.CoreFoundation            0x903445f5 CFRunLoopRunSpecific +
 3141
 7   com.apple.CoreFoundation            0x90344cd8 CFRunLoopRunInMode + 88
 8   com.apple.HIToolbox                 0x904412c0
 RunCurrentEventLoopInMode + 283
 9   com.apple.HIToolbox                 0x904410d9 ReceiveNextEventCommon
 + 374
 10  com.apple.HIToolbox                 0x90440f4d
 BlockUntilNextEventMatchingListInMode + 106
 11  com.apple.AppKit                    0x94326d7d _DPSNextEvent + 657
 12  com.apple.AppKit                    0x94326630 -[NSApplication
 nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
 13  com.apple.AppKit                    0x9431f66b -[NSApplication run] +
 795
 14  com.apple.AppKit                    0x942ec8a4 NSApplicationMain + 574
 15  com.adiumX.adiumX                   0x00002c62 _start + 216
 16  com.adiumX.adiumX                   0x00002b89 start + 41
 }}}


 When I looked in nexus.c I saw that the contact server still was defined
 as contacts.msn.com there and it's omega.contacts.msn.com in contact.h
 nowadays. This probably won't cause this or any other problems but who
 knows so I changed it.

 I'm using revision f25098a2d77f411e2436ce8e02d7cd70d99fb6a7.

 Don't mind "(Libpurple: cdsa) receive failed (-9802): Unknown error: 0" in
 the debug log because it's normal in Adium.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8415>
Pidgin <http://pidgin.im>
Pidgin