[Pidgin] #7516: XMPP "headline" messages create new conversation tab in 2.5.2
Pidgin
trac at pidgin.im
Mon Jan 5 18:44:18 EST 2009
#7516: XMPP "headline" messages create new conversation tab in 2.5.2
-------------------+--------------------------------------------------------
Reporter: jts | Owner: deryni
Type: patch | Status: new
Milestone: | Component: XMPP
Version: 2.5.2 | Resolution:
Keywords: |
-------------------+--------------------------------------------------------
Comment(by jts):
Replying to [comment:8 darkrain42]:
> Minimal is good (at least, IMHO), but the advantage of opt-in is that
the code really should only be creating a conversation and parsing for
custom smileys in the cases where the message will be displayed with the
smileys, which is why I believe it is correct to enumerate the allowed
cases (alternatively, one could explicitly disallow the incorrect cases of
error, headline, etc...)
Gotcha. Considering the different message types, this should be what we
want:
{{{
} else if (jm->type == JABBER_MESSAGE_NORMAL || jm->type ==
JABBER_MESSAGE_CHAT)
}}}
It looks like JABBER_MESSAGE_GROUPCHAT is the only other message type that
you'd see in a conversation, and that's explicitly handled separately.
I can submit this as a real diff, let me know... Thanks.
--
Ticket URL: <http://developer.pidgin.im/ticket/7516#comment:9>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list